Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: global date time formatting through i18n #2552

Merged
merged 27 commits into from
Jun 17, 2024

Conversation

khushal87
Copy link
Member

@khushal87 khushal87 commented Jun 13, 2024

馃幆 Goal

The goal of the PR is to introduce datetime formatting through i18n in the SDK. This will allow having one source of truth for all date time formatting. Please refer to the doc guide in the same PR to know more about the implementation.

Fixes #2104 as well

馃洜 Implementation details

馃帹 UI Changes

iOS
Before After
Android
Before After

馃И Testing

鈽戯笍 Checklist

  • I have signed the Stream CLA (required)
  • PR targets the develop branch
  • Documentation is updated
  • New code is tested in main example apps, including all possible scenarios
    • SampleApp iOS and Android
    • Expo iOS and Android

@MartinCupela MartinCupela self-requested a review June 14, 2024 14:14
@khushal87 khushal87 merged commit 0ad7016 into develop Jun 17, 2024
6 checks passed
@khushal87 khushal87 deleted the datetime-global-formatting branch June 17, 2024 09:01
@github-actions github-actions bot mentioned this pull request Jun 17, 2024
6 tasks
@stream-ci-bot
Copy link
Contributor

馃帀 This PR is included in version 5.32.0 馃帀

The release is available on:

Your semantic-release bot 馃摝馃殌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[馃悰] Can not change stickyHeaderFormatDate format, hardcoded value
4 participants