Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve frontend monomorphization to not generate identical methods when calling the same method #5904

Closed
IGI-111 opened this issue Apr 23, 2024 · 0 comments 路 Fixed by #5967
Closed

Improve frontend monomorphization to not generate identical methods when calling the same method #5904

IGI-111 opened this issue Apr 23, 2024 · 0 comments 路 Fixed by #5967
Assignees
@esdrubal
Labels
code quality compiler: frontend Everything to do with type checking, control flow analysis, and everything between parsing and IRgen performance Everything related to performance, speed wise or memory wise.

Comments

@IGI-111
Copy link
Contributor

IGI-111 commented Apr 23, 2024

No description provided.

@IGI-111 IGI-111 changed the title improve frontend monomorphization to not generate identical methods when calling the same method Improve frontend monomorphization to not generate identical methods when calling the same method Apr 23, 2024
@IGI-111 IGI-111 added code quality compiler: frontend Everything to do with type checking, control flow analysis, and everything between parsing and IRgen performance Everything related to performance, speed wise or memory wise. labels Apr 23, 2024
esdrubal added a commit that referenced this issue May 6, 2024
@esdrubal
Adds method and function deduplication to frontend.
8e67524 
Adds function cached to query engine, and reuses previously compiled methods and functions.

Closes #5904.
@esdrubal esdrubal mentioned this issue May 6, 2024
Merged
8 tasks
esdrubal added a commit that referenced this issue May 6, 2024
@esdrubal
Adds method and function deduplication to frontend.
1b48780 
Adds function cached to query engine, and reuses previously compiled methods and functions.

Closes #5904.
esdrubal added a commit that referenced this issue May 20, 2024
@esdrubal
Adds method and function deduplication to frontend.
1353d41 
Adds function cached to query engine, and reuses previously compiled methods and functions.

Closes #5904.
esdrubal added a commit that referenced this issue Jun 13, 2024
@esdrubal
Adds method and function deduplication to frontend.
1c40aff 
Adds function cached to query engine, and reuses previously compiled methods and functions.

Closes #5904.
esdrubal added a commit that referenced this issue Jun 14, 2024
@esdrubal
Adds method and function deduplication to frontend.
869c324 
Adds function cached to query engine, and reuses previously compiled methods and functions.

Closes #5904.
IGI-111 pushed a commit that referenced this issue Jun 17, 2024
@esdrubal
Adds method and function deduplication to frontend. (#5967)
b5fa25a 
## Description

Adds function cached to query engine, and reuses previously compiled
methods and functions.

Closes #5904.

## Checklist

- [x] I have linked to any relevant issues.
- [x] I have commented my code, particularly in hard-to-understand
areas.
- [ ] I have updated the documentation where relevant (API docs, the
reference, and the Sway book).
- [ ] If my change requires substantial documentation changes, I have
[requested support from the DevRel
team](https://github.com/FuelLabs/devrel-requests/issues/new/choose)
- [x] I have added tests that prove my fix is effective or that my
feature works.
- [x] I have added (or requested a maintainer to add) the necessary
`Breaking*` or `New Feature` labels where relevant.
- [x] I have done my best to ensure that my PR adheres to [the Fuel Labs
Code Review
Standards](https://github.com/FuelLabs/rfcs/blob/master/text/code-standards/external-contributors.md).
- [x] I have requested a review from the relevant team or maintainers.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@esdrubal esdrubal

Labels
code quality compiler: frontend Everything to do with type checking, control flow analysis, and everything between parsing and IRgen performance Everything related to performance, speed wise or memory wise.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Adds method and function deduplication to frontend. FuelLabs/sway
2 participants
@esdrubal @IGI-111