Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] - overrideConfig not passed to Langsmith #2421

Open
blackge opened this issue May 16, 2024 · 5 comments
Open

[BUG] - overrideConfig not passed to Langsmith #2421

blackge opened this issue May 16, 2024 · 5 comments
Labels
bug Something isn't working

Comments

@blackge
Copy link

blackge commented May 16, 2024

Describe the bug
When using overrideConfig to set tags and metadata in LangSmith, it is not passing the data through to langsmith.

To Reproduce
Steps to reproduce the behavior:

When calling prediction API, set overrideConfig

overrideConfig: {
      "analytics": {
        "langSmith": {
          "tags": ["DEI"],
          "metadata": {
            "sessionId": sessionId ? sessionId : "123",
          }
        }
      }
    }

Expected behavior
Metadata should appear in Langsmith

Screenshots
Metadata does not appear.

Screenshot 2024-05-16 at 12 16 27

Setup

  • Installation on Railway
  • Flowise Version 1.6.5
  • OS: [e.g. macOS, Windows, Linux]
  • Browser [e.g. chrome, safari]

Additional context
This is possibly a documentation issue and an example is needed. However looking at the code in /packages/src/components/handler.ts the additionalHandlers isn't passing the options into the langSmith trace. Assuming options is what is passed in from the overrideConfig, this would explain why it doesn't get passed through. The same issue applies to the Langfuse call.

@Zulelee
Copy link

Zulelee commented May 16, 2024

The same happens for me for Pinecone for the prediction API. It does not override the value for pineconeNamespace. It used to work before.

@HenryHengZJ
Copy link
Contributor

The same happens for me for Pinecone for the prediction API. It does not override the value for pineconeNamespace. It used to work before.

i think its a different issue because this is related to analytics.

Can confirm overriding pinconeNamespace works:
1.) I have a Pinecone node on canvas with namespace: pinecone-flowise-docs:
image

2.) Overriding on API to testing-1
image

3.) Pincone dashboard:
image

@Zulelee
Copy link

Zulelee commented May 17, 2024

@HenryHengZJ It works while upserting vectors for me as well. But, when I use the prediction API and override the pineconeNamespace, it does not get the vectors for the context from the pinecone namespace specified in the call and instead gets the vectors from the default one set on flowise.

@HenryHengZJ HenryHengZJ added the bug Something isn't working label May 18, 2024
@HenryHengZJ
Copy link
Contributor

@HenryHengZJ It works while upserting vectors for me as well. But, when I use the prediction API and override the pineconeNamespace, it does not get the vectors for the context from the pinecone namespace specified in the call and instead gets the vectors from the default one set on flowise.

Its working fine from testing:

1.) Have the same Pinecone node on canvas with namespace: pinecone-flowise-docs
2.) Use the prediction API and override pineconeNamespace:
image
3.) Can see the Pinecone namespace correctly passed from overrideConfig:
image

@blackge
Copy link
Author

blackge commented May 27, 2024

@HenryHengZJ Can you check if you are able to reproduce the original Langsmith error? This bug got derailed from the original.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants