Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Escape pipes. It makes wrong render as tables in Kramdown/GFM engines #6723

Merged
merged 1 commit into from
Feb 14, 2022

Conversation

davorpa
Copy link
Member

@davorpa davorpa commented Feb 14, 2022

What does this PR do?

Improve repo

For resources

Description

GitHub Pages is a bit tricky. Pipes | make wrong render as tables using any Kramdown/GFM ruby engines, independenly if is present inside link or it hasn't table header syntax.

Replacement using regexp search: (?<!\\)\|

Why is this valuable (or not)?

This PR delve with it until up to date but linter needs be replugged in to definitelly solve #5176

Checklist:

Follow-up

  • Check the status of GitHub Actions and resolve any reported warnings!

@davorpa davorpa added the 🐛 BUG Confirmed bugs, normally at GitHub Pages label Feb 14, 2022
@davorpa davorpa self-assigned this Feb 14, 2022
@davorpa davorpa linked an issue Feb 14, 2022 that may be closed by this pull request
@davorpa davorpa marked this pull request as ready for review February 14, 2022 05:07
@eshellman eshellman merged commit c72c0d5 into EbookFoundation:main Feb 14, 2022
@davorpa davorpa mentioned this pull request Apr 30, 2022
5 tasks
@davorpa davorpa mentioned this pull request Jun 9, 2022
5 tasks
davorpa added a commit to AgilAghamirzayev/free-programming-books that referenced this pull request Jul 24, 2022
eshellman pushed a commit that referenced this pull request Jul 25, 2022
* Update free-courses-en.md

* format: Remove video timing param from ulrs and escape pipes from titles

Addresses #6723

* format: escape markdown tokens from resource title

Co-authored-by: David Ordás <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 BUG Confirmed bugs, normally at GitHub Pages
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Mark up look strange on the site when using pipes |
2 participants