Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support BMI exchange of wflow variables through listing of model variables in the TOML file #391

Open
verseve opened this issue Apr 17, 2024 · 0 comments
Labels
coupling For coupling Wflow to other models/software user-experience Improvements to the settings file, logging, error handling, etc. v1.0 Activities related to v1.0

Comments

@verseve
Copy link
Member

verseve commented Apr 17, 2024

Feature type

Changing existing functionality

Improvement Description

The variables that wflow can exchange through BMI are now based on the different model components, these can be listed under the API section of the TOML configuration file. The variables that can be exchanged for each model component depend on the @exchange metadata setting for each field in a wflow struct. For coupling applications (e.g. with OpenDA) it would make sense to also have the option to control the exchange at the model variable level, by listing these variables in the TOML file.

Implementation Description

Instead of components have the option to use variables in the configuration TOML file, and change function BMI.get_input_var_names to support this.

Additional Context

No response

@verseve verseve added user-experience Improvements to the settings file, logging, error handling, etc. coupling For coupling Wflow to other models/software v1.0 Activities related to v1.0 labels Apr 17, 2024
@verseve verseve changed the title Support BMI exchange of wflow variables through lsisting of model variables in the TOML file Support BMI exchange of wflow variables through listing of model variables in the TOML file Apr 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
coupling For coupling Wflow to other models/software user-experience Improvements to the settings file, logging, error handling, etc. v1.0 Activities related to v1.0
Projects
None yet
Development

No branches or pull requests

1 participant