Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The preview attribute in a link does not take into account false #93

Open
gerardnico opened this issue Apr 7, 2024 Discussed in #92 · 6 comments
Open

The preview attribute in a link does not take into account false #93

gerardnico opened this issue Apr 7, 2024 Discussed in #92 · 6 comments
Assignees
Labels
done Done (The user should give feedback or close the issue) enhancement New feature or request good first issue Good for newcomers

Comments

@gerardnico
Copy link
Member

Discussed in #92

Originally posted by vaniwiki April 7, 2024
I like automatic tooltips, showing relevant information across my website. But they should not be everywhere. For example, I have a long list of links that do not need any link tooltips, but just remain as links. Is there any way to turn this feature off for certain parts, like a box or card with some syntax like <box tooltip="none"> or similar...?

@gerardnico gerardnico added enhancement New feature or request good first issue Good for newcomers labels Apr 7, 2024
@gerardnico gerardnico changed the title Is it possible to turn off automatic tooltips for selection? The preview attribute in a link does not take into account false Apr 7, 2024
@gerardnico
Copy link
Member Author

The preview attribute in a link does not take into account the value false.

@gerardnico
Copy link
Member Author

This link should not return any tooltip

[[?preview=false|preview of the actual page]]

@gerardnico
Copy link
Member Author

It comes from this line where the code set true if the attribute is present and does not check the value at all.

@vaniwiki
Copy link

This would be very helpful combined with iterator, so I can turn off redundant descriptions where I already show them in its fragment... Previosuly my autotooltip plugin showed me only tooltips from certain places, only in certain places, so I could control more easily where tooltips would display... (They had a namespace list with regex for include or exclude. I think that shold come as standard with every plugin, actually.)

gerardnico added a commit that referenced this issue Apr 15, 2024
@gerardnico
Copy link
Member Author

Done

@gerardnico gerardnico self-assigned this Apr 15, 2024
@gerardnico gerardnico added the done Done (The user should give feedback or close the issue) label Apr 15, 2024
@vaniwiki
Copy link

Here is another aspect of the same issue:

The ?preview=false argument may not show the preview, but it still shows full description on hover as the browser tooltip.

Is there a way to make it show only the page-id, like how DokuWiki usually works, when ?preview=false flag is given?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
done Done (The user should give feedback or close the issue) enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants