Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Creating a brochure app through golem does not import {brochure} #40

Open
teofiln opened this issue Apr 26, 2022 · 2 comments
Open

Creating a brochure app through golem does not import {brochure} #40

teofiln opened this issue Apr 26, 2022 · 2 comments

Comments

@teofiln
Copy link

teofiln commented Apr 26, 2022

Following the Readme:

golem::create_golem("testbrochure", project_hook = brochure::golem_hook)

Creates a blank brochure app. But,

> devtools::load_all(".")
ℹ Loading testbrochure
> run_app()
Error in brochureApp(golem_add_external_resources(), home(), onStart = onStart,  : 
  could not find function "brochureApp"

And the DESCRIPTION does not import {brochure}:

Package: testbrochure
Title: An Amazing Shiny App
Version: 0.0.0.9000
Authors@R: 
    person(given = "firstname",
           family = "lastname",
           role = c("aut", "cre"),
           email = "[email protected]")
Description: What the package does (one paragraph).
License: What license is it under?
Imports: 
    config (>= 0.3.1),
    golem (>= 0.3.1),
    shiny (>= 1.7.1)
Encoding: UTF-8
LazyData: true
RoxygenNote: 7.1.1

The workaround is of course trivial,

usethis::use_package("brochure", min_version = TRUE)

but ideally this import would be declared by the function (like {golem} and {shiny})

@ColinFay Not sure if this is best filed under a {brochure} or {golem}?

@ColinFay
Copy link
Owner

This is to be filled here, thanks :)

I'll have a look into that. If possible I'll try to avoid adding {usethis} as a dep to {brochure} .

Thanks for reporting !

@teofiln
Copy link
Author

teofiln commented Apr 26, 2022

Thanks Colin!

Didn't mean to suggest to add usethis as a dependency. Just to mention how one can bypass the problem while a suitable solution is in place.

Thanks for writing all these incredible tools and sharing them with the community!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants