Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update(linting): update contribuition guide and remove deprecated linting methods #7159

Merged
merged 6 commits into from
Jun 28, 2024
Merged

update(linting): update contribuition guide and remove deprecated linting methods #7159

merged 6 commits into from
Jun 28, 2024

Conversation

ArturRibeiro-CX
Copy link
Contributor

Closes #7144

Reason for Proposed Changes

  • change contribution guide linting method suggestion;
  • remove deprecated linting methods;

Proposed Changes

  • remove deprecated linting methods from golangci.yaml;
  • update contribution guide with current linting method used by KICS Repo;

I submit this contribution under the Apache-2.0 license.

@ArturRibeiro-CX ArturRibeiro-CX requested a review from a team as a code owner June 26, 2024 14:01
@github-actions GitHub Actions
Copy link
Contributor

kics-logo

KICS version: v2.1.0

Category Results
CRITICAL CRITICAL 0
HIGH HIGH 0
MEDIUM MEDIUM 0
LOW LOW 0
INFO INFO 0
TRACE TRACE 0
TOTAL TOTAL 0
Metric Values
Files scanned placeholder 1
Files parsed placeholder 1
Files failed to scan placeholder 0
Total executed queries placeholder 48
Queries failed to execute placeholder 0
Execution time placeholder 0

@ArturRibeiro-CX ArturRibeiro-CX merged commit 82b7501 into master Jun 28, 2024
25 checks passed
@ArturRibeiro-CX ArturRibeiro-CX deleted the deprecated_linting_methods branch June 28, 2024 09:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cxMiguelSilva cxMiguelSilva cxMiguelSilva approved these changes

@cx-andrep cx-andrep cx-andrep approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

bug(contributionguide): removal of deprecated golint
3 participants
@ArturRibeiro-CX @cxMiguelSilva @cx-andrep