Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature]: Manually allow running CircleCI unit tests on PRs (safely) #4157

Open
Manouchehri opened this issue Jun 12, 2024 · 1 comment
Open
Assignees
Labels
enhancement New feature or request

Comments

@Manouchehri
Copy link
Collaborator

The Feature

This ticket is for writing down notes before I forget. If you're not me, you can ignore this for now.

Self notes:

https://stackoverflow.com/a/62602611/2079814

And then I should filter on:

on:
  pull_request_review:
    types: [submitted]

jobs:
  approved:
    if: github.event.review.state == 'APPROVED' && github.event.review.user.login == "Manouchehri" && github.event.sender.login == "Manouchehri"
    runs-on: ubuntu-latest
    steps:
      - run: echo "This PR was approved"

https://docs.github.com/en/webhooks/webhook-events-and-payloads#pull_request_review

Motivation, pitch

Let's not give everybody a heart attack when merging into main.

Twitter / LinkedIn details

https://www.linkedin.com/in/davidmanouchehri/

@Manouchehri Manouchehri added the enhancement New feature or request label Jun 12, 2024
@Manouchehri Manouchehri self-assigned this Jun 12, 2024
@Manouchehri
Copy link
Collaborator Author

@krrishdholakia Would changing the settings on this repo to Require approval for all outside collaborators break any of your current dev workflow? (I'm assuming/guessing the answer is no; if that's correct, then I think I know how to get CircleCI tests running on PRs safely and sanely.)

https://github.com/BerriAI/litellm/settings/actions

For security reasons, if we start running CircleCI stuff on forked branches, Require approval for all outside collaborators should really be enabled.

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant