-
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TimePicker No Select Second #12045
Comments
I believe this control is migrated from winui, the original design is like this. Need some improvement. |
I need this, too. |
This design is actually unreasonable. It may not take seconds on apps, but selecting seconds on PCs is necessary and switch control can be added |
I think this should be controllable by a property. I don't know which one would be best. I think either
|
Need seconds. Or another type TimePicker with seconds. |
microsoft/microsoft-ui-xaml#1440
So, yes - it is "by design". Can be changed though. |
Okay, so for now we need to wait for upstream to decide or for the team to have enough time to decide which API is probably the best for Avalonia. Right now I suggest to write a custom control for your usage. If you want, you can share the control in this issue and if later someone thinks it's the right approach, it still can be merged in. |
Well, I don't think we should EVER wait for upstream. WinUI is dying down quite a bit in areas like this. I would be very surprised if there is ever any movement in this space. I do expect they are cooking up several things behind the scenes for Windows 12 though. That said:
I kind-of agree with this. Second selection is valid in some cases but not for most. I don't think we should complicate the control unless a really good design is found. Perhaps the design is simply to add an optional seconds column which might be fairly straightforward though. These controls (DatePicker and TimePicker) are also a bit tricky simply due to the way the flyout presenters work. It may not be a great beginning project -- who knows though and I don't want to discourage anything. Since controls are so widely used I highly suggest providing a visual design for the changes you are proposing and then even a mock-up before any coding here starts. |
Hi! |
@mate1213 I think my comment is still valid: #12045 (comment) So I see 2 options you can help:
If you go with 2), make sure to read build instructions. |
Great! |
Just dropping in to say I need a TimePicker that supports seconds too and was quite surprised to see that this isn't a supported feature of TimePicker. |
I've submitted PR #16079 that adds a new |
why?
The text was updated successfully, but these errors were encountered: