11.1.0-rc1

[grokys]

This release contains bugfixes for issues reported for 11.1.0-beta2. If no showstoppers are reported this will become 11.1.0.

Full Changelog: 11.1.0-beta2...11.1.0-rc1

---

This discussion was created from the release 11.1.0-rc1.

[StefanKoell]

I'm confused. I'm desperately waiting for this PR to be released and it's still not in the 11.1.0-rc1?

[timunie]

it has the 11.1 backport label, which means will be in 11.1.1 if I understood correctly. For 11.1.0 it's too late I think.

[StefanKoell]

well, if that's not confusing... anyhow, thanks for the clarification. I hope it will be included then.

[grokys]

Yeah the 11.1 release has been trapped in feature creep hell for the last I don't know how many months. We're trying to get out of that now, so only showstopper bug fixes will be merged in the beta -> RC phase.

[viktorspacil]

Hi, I switch to RC1 from v11.0.11 and I encountered following "problems":

• I had to newly explicitly register DefaultValueConverter for bindings to automatically convert Methods to ICommand, is this intended?
• Custom converter specified on binding is newly called only once at init and not with every PropertyChange event (fired from ViewModel), is this intended?
• Avalonia.Xaml.Behaviors: I had EventTriggerBehavior with SourceObject="{Binding $self}" when EventTriggerBehavior element was nested directly within Window element for example. I had to switch to SourceObject="{Binding ElementName=AppWindow}" because syntax using $self stopped referencing the parent Window element (application crash), is this intended?
  Am I missing something? Thank you.

[grokys]

I had to newly explicitly register DefaultValueConverter for bindings to automatically convert Methods to ICommand, is this intended?

Do you mean you're trying to do something like <Button Command="{Binding Foo}"/> where Foo is a method on your view model? That should definitely work: we have unit tests for it and I just tested it manually and it seems to work with both compiled and reflection bindings.

Custom converter specified on binding is newly called only once at init and not with every PropertyChange event (fired from ViewModel), is this intended?

Do you mean a value converter specified in a binding, e.g. <TextBlock Text="{Binding Bar, Converter={x:Static local:FooConverter.Instance}}"/ ? Again, this is something that I've just tried and didn't see any problems (and we also have unit tests for).

I suspect you might be hitting some edge cases in these issues, so yeah a repro would be helpful 🙏

[viktorspacil]

Bug #2 - DefaultValueConverter, below is slightly modified starting template of Avalonia MVVM project.

This is a working code (I had to newly and explicitly register and set the default value converter for the binding):

<Window
    Icon="/Assets/avalonia-logo.ico"
    Title="TestApp"
    d:DesignHeight="450"
    d:DesignWidth="800"
    mc:Ignorable="d"
    x:Class="TestApp.Views.MainWindow"
    x:DataType="vm:MainWindowViewModel"
    xmlns="https://github.com/avaloniaui"
    xmlns:d="http://schemas.microsoft.com/expression/blend/2008"
    xmlns:mc="http://schemas.openxmlformats.org/markup-compatibility/2006"
    xmlns:vm="using:TestApp.ViewModels"
    xmlns:x="http://schemas.microsoft.com/winfx/2006/xaml">

    <Window.Styles>
        <Style Selector="Button.ClickMe">
            <Setter Property="Command" Value="{Binding TestMethod, Converter={StaticResource DefaultValueConverter}}" />
        </Style>
    </Window.Styles>

    <StackPanel Orientation="Vertical">
        <TextBlock
            HorizontalAlignment="Center"
            Text="{Binding Greeting}"
            VerticalAlignment="Center" />
        <Button
            Classes="ClickMe"
            Content="Click me"
            HorizontalAlignment="Center" />
    </StackPanel>

</Window>

This is not working (button is grey out/disabled, this code was working with v11.0.10 but is not working with the rc1):

<Window
    Icon="/Assets/avalonia-logo.ico"
    Title="TestApp"
    d:DesignHeight="450"
    d:DesignWidth="800"
    mc:Ignorable="d"
    x:Class="TestApp.Views.MainWindow"
    x:DataType="vm:MainWindowViewModel"
    xmlns="https://github.com/avaloniaui"
    xmlns:d="http://schemas.microsoft.com/expression/blend/2008"
    xmlns:mc="http://schemas.openxmlformats.org/markup-compatibility/2006"
    xmlns:vm="using:TestApp.ViewModels"
    xmlns:x="http://schemas.microsoft.com/winfx/2006/xaml">

    <Window.Styles>
        <Style Selector="Button.ClickMe">
            <Setter Property="Command" Value="{Binding TestMethod}" />
        </Style>
    </Window.Styles>

    <StackPanel Orientation="Vertical">
        <TextBlock
            HorizontalAlignment="Center"
            Text="{Binding Greeting}"
            VerticalAlignment="Center" />
        <Button
            Classes="ClickMe"
            Content="Click me"
            HorizontalAlignment="Center" />
    </StackPanel>

</Window>

So it seems that the converters stopped working for binding which are set using styles.

[timunie]

please provide a minimal sample in a new issue. Need to be inspected deeper.

[viktorspacil]

I have created issue #16113.

[viktorspacil]

Hi, I also created an issue #16137 (with minimal sample) for the problem with the custom converter which is called only once at startup.

[dbriard]

Could you fix this issue with Text that has a width if 0 when TextAlignment is not Left in 11.1? #16009
I am using HorizontalAlignment as a workaround but the rendering is not correct for multilines texts.

[grokys]

Not in the release candidate state, no, sorry. This stage is limited to showstopper bugs. A fix for that can likely go into 11.1.x though.

[cricketthomas]

Since upgrading from 11.1.0-beta2 to 11.1.0-rc1 I have noticed a small difference in text rendering when the background is set to Mica, is this expected? The text looks a bit thicker/more bold. It can be fixed by setting the text to RenderOptions.TextRenderingMode="Antialias"

11.1.0-beta2

11.1.0-rc1

[Gillibald]

That is a known bug with layering

[Gillibald]

That is a known bug with layering

Non opaque backgrounds are also not working well with sub pixel rendering