Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: rename upload_dataset_examples to upload_dataset and add return type #3607

Merged
merged 1 commit into from
Jun 21, 2024

Conversation

axiomofjoy
Copy link
Contributor

resolves #3605

@dosubot dosubot bot added the size:XXL This PR changes 1000+ lines, ignoring generated files. label Jun 21, 2024
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@axiomofjoy axiomofjoy changed the base branch from main to datasets June 21, 2024 20:12
@dosubot dosubot bot added size:M This PR changes 30-99 lines, ignoring generated files. and removed size:XXL This PR changes 1000+ lines, ignoring generated files. labels Jun 21, 2024
@axiomofjoy axiomofjoy force-pushed the xander/upload-datasets-return-value branch from cfa5c8a to 8eb9ad7 Compare June 21, 2024 20:14
@axiomofjoy axiomofjoy merged commit bb25741 into datasets Jun 21, 2024
11 checks passed
@axiomofjoy axiomofjoy deleted the xander/upload-datasets-return-value branch June 21, 2024 20:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size:M This PR changes 30-99 lines, ignoring generated files.
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

[datasets][REST] /v1/datasets/<dataset_id>/upload should return 409 on conflict
2 participants