Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ext-CSS rules with 'remove' don't work in apps at hotcleaner.com #139

Open
AdamWr opened this issue Dec 15, 2021 · 1 comment
Open

Ext-CSS rules with 'remove' don't work in apps at hotcleaner.com #139

AdamWr opened this issue Dec 15, 2021 · 1 comment
Labels

Comments

@AdamWr
Copy link
Member

AdamWr commented Dec 15, 2021

Similar issue as here - #127

Steps to reproduce:

  1. Use AdGuard app
  2. Add this rule to user rules:
hotcleaner.com#$?#body { remove: true; }
  1. Go here - https://www.hotcleaner.com/

Website should be blank, but extended CSS rules with remove do not work.
I guess that it happens, because website override Element.prototype.remove and Element.prototype.removeChild function.

@ameshkov ameshkov added the bug label Dec 15, 2021
@ameshkov
Copy link
Member

Relatively easy to fix, we should save reference to these functions.

@adguard-bot adguard-bot changed the title Ext-CSS rules with remove don't work in apps at hotcleaner.com Ext-CSS rules with 'remove' don't work in apps at hotcleaner.com Jan 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants