Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Persistent snack about auto-update failure on Updates screen, MIUI 13 #5334

Open
4 of 6 tasks
Nzzyme opened this issue May 26, 2024 · 6 comments
Open
4 of 6 tasks

Persistent snack about auto-update failure on Updates screen, MIUI 13 #5334

Nzzyme opened this issue May 26, 2024 · 6 comments

Comments

@Nzzyme
Copy link

Nzzyme commented May 26, 2024

Please answer the following questions for yourself before submitting an issue

  • Filters were updated before reproducing an issue
  • I checked the knowledge base and found no answer
  • I checked to make sure that this issue has not already been filed

AdGuard version

4.4.1

Environment

  • OS version: MIUI 13 (Android 12)

HTTPS filtering

  • yes, I do

Root access

  • yes, I have it

Integration with AdGuard VPN

  • yes, I do

Routing mode

Local VPN

Ad Blocking

No response

Privacy

No response

Social

No response

Annoyances

No response

Security

No response

Language-specific

No response

Other

No response

Which DNS server do you use?

AdGuard DNS

DNS protocol

None

Custom DNS

No response

What Stealth Mode options do you have enabled?

No response

Issue Details

Steps to reproduce:

  1. Open AG
  2. Tap on the update filters icon (top-right). On the next page, we see the filters getting updated. On this same page, we see a message at the bottom saying "auto-updated may fail" with a "fix it" button.
  3. Click on Fix it
  4. On the next page, click on Allow button.
  5. It redirects to system level battery optimisation settings. Select "No restriction". The page returns back and we still see the "Allow" button again.

Expected Behavior

After clicking on Allow button it should take us to the system level battery optimisation page and when we select no restriction it should accept that and save it.

Actual Behavior

It goes in a loop and ask us again and again to allow the battery optimisation settings as seen in the attached video.

Video: https://jmp.sh/s/qjYppMPO5zwgVDaHSTXc

Screenshots

Screenshot 1

Additional Information

No response

@Nzzyme Nzzyme added the Bug label May 26, 2024
@Versty Versty changed the title Persistent message about auto-update failure Persistent snack about auto-update failure on Updates screen, MIUI 13 May 27, 2024
@Versty
Copy link
Contributor

Versty commented May 27, 2024

@Nzzyme Thank you for reporting!
This behaviour is specific to MIUI and is controlled by the OS itself.
We will consider removing the snack for Xiaomi devices.

@Schism86
Copy link

@Nzzyme Thank you for reporting! This behaviour is specific to MIUI and is controlled by the OS itself. We will remove the snack for Xiaomi devices.

I have the same problem with Hyperos 1.0.1.0 on my Poco F3.
However, it does not stop at this rather cosmetic problem, but there is also the following effect:
When I connect to a WLAN, my Internet connection does not work until I actively start Adguard.

@Nzzyme
Copy link
Author

Nzzyme commented May 28, 2024

@Nzzyme Thank you for reporting! This behaviour is specific to MIUI and is controlled by the OS itself. We will consider removing the snack for Xiaomi devices.

The snack bar should not be completely removed by default. The expected behavior is that it should be shown if AG is set to be optimized by the OS. If not, it should not be shown.

If AG is set to be optimized by the OS, then when we click on "Fix it" and then on "Allow" button, it should take us to the optimization page and when we select as "No restriction", it should save that value and then the snack bar should no longer be shown in the future.

@Nzzyme
Copy link
Author

Nzzyme commented May 28, 2024

@Nzzyme Thank you for reporting! This behaviour is specific to MIUI and is controlled by the OS itself. We will remove the snack for Xiaomi devices.

I have the same problem with Hyperos 1.0.1.0 on my Poco F3. However, it does not stop at this rather cosmetic problem, but there is also the following effect: When I connect to a WLAN, my Internet connection does not work until I actively start Adguard.

It seems to be a different issue and not related to battery optimisation. Anyway, I think what you are going through is due to a setting in the MIUI Settings app. Try this:

  1. Open system Settings app
  2. Open the "VPN" settings. AG should be displayed there.
  3. Click on the settings icon against AG. (Do not click on AG but only on the Settings icon against AG).
  4. Disable the option "Block connections without VPN" and enable the option "Always-on VPN"

That might fix it.

@Versty
Copy link
Contributor

Versty commented May 28, 2024

@Nzzyme

If AG is set to be optimized by the OS, then when we click on "Fix it" and then on "Allow" button, it should take us to the optimization page and when we select as "No restriction", it should save that value and then the snack bar should no longer be shown in the future.

The battery optimisation settings are controlled by the OS. For some reason, when you select "No restriction" for the AdGuard application, MIUI automatically discards your action and sets the option to the default "Optimised" position.

The snack bar should not be completely removed by default. The expected behavior is that it should be shown if AG is set to be optimized by the OS. If not, it should not be shown.

The snack is designed and is currently works this way. But due to OS behaviour on MIUI devices, the battery optimisation setting fails to be saved in "No restriction" position and the snack re-appears every time.

@Nzzyme
Copy link
Author

Nzzyme commented Jun 27, 2024

The battery optimisation settings are controlled by the OS. For some reason, when you select "No restriction" for the AdGuard application, MIUI automatically discards your action and sets the option to the default "Optimised" position.

The snack is designed and is currently works this way. But due to OS behaviour on MIUI devices, the battery optimisation setting fails to be saved in "No restriction" position and the snack re-appears every time.

Then how is it working fine with other apps (Example: Truecaller). I installed Truecaller and when the TC app ask for battery optimisation setting, I select "No restriction" and the setting is saved. without any problem. Hence, I don't think the issue with AG not saving the setting is due to MIUI. I believe this should be fixed within AG.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants